Google Git
Sign in
android / platform / frameworks / support / f69f336286dc3c3025657edd8d507be41f732829
commitf69f336286dc3c3025657edd8d507be41f732829[log] [tgz]
authorAlexandre Elias <[email protected]>Tue Jun 06 00:50:46 2023 +0000
committerAndroid Build Coastguard Worker <[email protected]>Thu Jun 08 21:36:55 2023 +0000
tree605c8080986607c9cce3e5e230b7f3a59a535ca8
parent79791f1dc63889351eb70fabb4d047d74b75c909 [diff]
Fix dialogs and popups to resize when usePlatformDefaultWidth=true

When usePlatformDefaultWidth=false mode was introduced in aosp/1733818
and aosp/1686520, the logic in internalOnLayout accidentally broke
the usePlatformDefaultWidth=true mode.
* In 'false' mode, measure ignores the ViewRootImpl constraints, and
  layout fixes a window size. This mode behaved correctly.
* In 'true' mode, measure respects the ViewRootImpl constraints,
  therefore window params should remain WRAP_CONTENTS instead of getting
  set to a fixed size. The window params wind up fed back into measure,
  therefore prior to this patch, the size would never change again after
  initialization.

Test: New tests DialogTest.canChangeSize & PopupTest.canChangeSize
Bug: 221643630
(cherry picked from https://android-review.googlesource.com/q/commit:f0db452fb69fb142eb8c3bd1b8f382f324d7cc7e)
Merged-In: I112ee69d0b9568416ce0ffa45cee42392f467356
Change-Id: I112ee69d0b9568416ce0ffa45cee42392f467356
5 files changed
tree: 605c8080986607c9cce3e5e230b7f3a59a535ca8
  1. .github/
  2. .idea/
  3. activity/
  4. annotation/
  5. appactions/
  6. appcompat/
  7. appsearch/
  8. arch/
  9. asynclayoutinflater/
  10. autofill/
  11. benchmark/
  12. biometric/
  13. bluetooth/
  14. browser/
  15. buildSrc/
  16. buildSrc-tests/
  17. busytown/
  18. camera/
  19. car/
  20. cardview/
  21. collection/
  22. compose/
  23. concurrent/
  24. constraintlayout/
  25. contentpager/
  26. coordinatorlayout/
  27. core/
  28. credentials/
  29. cursoradapter/
  30. customview/
  31. datastore/
  32. development/
  33. docs/
  34. docs-kmp/
  35. docs-public/
  36. docs-tip-of-tree/
  37. documentfile/
  38. draganddrop/
  39. drawerlayout/
  40. dynamicanimation/
  41. emoji/
  42. emoji2/
  43. enterprise/
  44. exifinterface/
  45. external/
  46. fragment/
  47. frameworks/
  48. glance/
  49. gradle/
  50. graphics/
  51. gridlayout/
  52. health/
  53. heifwriter/
  54. hilt/
  55. input/
  56. inspection/
  57. interpolator/
  58. javascriptengine/
  59. leanback/
  60. lifecycle/
  61. lint-checks/
  62. loader/
  63. media/
  64. media2/
  65. mediarouter/
  66. metrics/
  67. navigation/
  68. paging/
  69. palette/
  70. percentlayout/
  71. placeholder/
  72. placeholder-tests/
  73. playground-common/
  74. preference/
  75. print/
  76. privacysandbox/
  77. profileinstaller/
  78. recommendation/
  79. recyclerview/
  80. remotecallback/
  81. resourceinspection/
  82. room/
  83. samples/
  84. savedstate/
  85. security/
  86. sharetarget/
  87. slice/
  88. slidingpanelayout/
  89. sqlite/
  90. stableaidl/
  91. startup/
  92. swiperefreshlayout/
  93. test/
  94. testutils/
  95. text/
  96. tracing/
  97. transition/
  98. tv/
  99. tvprovider/
  100. vectordrawable/
  101. versionedparcelable/
  102. viewpager/
  103. viewpager2/
  104. wear/
  105. webkit/
  106. window/
  107. work/
  108. .gitignore
  109. .mailmap
  110. build.gradle
  111. cleanBuild.sh
  112. code-review.md
  113. CONTRIBUTING.md
  114. gradle.properties
  115. gradlew
  116. libraryversions.toml
  117. LICENSE.txt
  118. OWNERS
  119. PREUPLOAD.cfg
  120. README.md
  121. settings.gradle
  122. studiow
  123. TEXT_OWNERS
README.md

Android Jetpack

Revved up by Gradle Enterprise

Jetpack is a suite of libraries, tools, and guidance to help developers write high-quality apps easier. These components help you follow best practices, free you from writing boilerplate code, and simplify complex tasks, so you can focus on the code you care about.

Jetpack comprises the androidx.* package libraries, unbundled from the platform APIs. This means that it offers backward compatibility and is updated more frequently than the Android platform, making sure you always have access to the latest and greatest versions of the Jetpack components.

Our official AARs and JARs binaries are distributed through Google Maven.

You can learn more about using it from Android Jetpack landing page.

Contribution Guide

For contributions via GitHub, see the GitHub Contribution Guide.

Note: The contributions workflow via GitHub is currently experimental - only contributions to the following projects are being accepted at this time:

Code Review Etiquette

When contributing to Jetpack, follow the code review etiquette.

Accepted Types of Contributions

  • Bug fixes - needs a corresponding bug report in the Android Issue Tracker
  • Each bug fix is expected to come with tests
  • Fixing spelling errors
  • Updating documentation
  • Adding new tests to the area that is not currently covered by tests
  • New features to existing libraries if the feature request bug has been approved by an AndroidX team member.

We are not currently accepting new modules.

Checking Out the Code

Head over to the onboarding docs to learn more about getting set up and the development workflow!

Continuous integration

Our continuous integration system builds all in progress (and potentially unstable) libraries as new changes are merged. You can manually download these AARs and JARs for your experimentation.

Password and Contributor Agreement before making a change

Before uploading your first contribution, you will need setup a password and agree to the contribution agreement:

Generate a HTTPS password: https://android-review.googlesource.com/new-password

Agree to the Google Contributor Licenses Agreement: https://android-review.googlesource.com/settings/new-agreement

Getting reviewed

  • After you run repo upload, open r.android.com
  • Sign in into your account (or create one if you do not have one yet)
  • Add an appropriate reviewer (use git log to find who did most modifications on the file you are fixing or check the OWNERS file in the project's directory)

Handling binary dependencies

AndroidX uses git to store all the binary Gradle dependencies. They are stored in prebuilts/androidx/internal and prebuilts/androidx/external directories in your checkout. All the dependencies in these directories are also available from google(), or mavenCentral(). We store copies of these dependencies to have hermetic builds. You can pull in a new dependency using our importMaven tool.