Skip to content

Commit 7ff3abe

Browse files
authored
Divide everything into v1, v2, and common (unexported). (#1149)
* Divide everything into v1, v2, and common (unexported). Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace. * Fix dependency conflicts * Lint fixes * Remove __trigger (#1150) * Remove __trigger * Lint fixes * Divide everything into v1, v2, and common (unexported). Did some refactoring, like putting `firebaseConfig` into common. This means we have absolutely no dependencies on v1 in common or v2. Some files are left at the root because they were modified in other CLs that are outstanding and I want to linearize the changes to minimize conflicts. While working, I removed some legacy workarounds that should no longer apply. For example, we no longer need to load fireaseConfig from runtime config because all supported versions of the CLI set the FIREBASE_CONFIG environment variable. This meant we could remove all of setup.ts because all monkeypatches were for outdated runtimes. Since there is no longer an environment change between importing v1/index and a subpackage, I've gone ahead and exported the providers for v1 to minimize customer frustration with the v1 namespace. * Fix dependency conflicts * Lint fixes * Remove __trigger (#1150) * Remove __trigger * Lint fixes * Move apps and utilities into common
1 parent bebb398 commit 7ff3abe

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+7005
-1836
lines changed

integration_test/run_tests.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ function deploy {
7878
./functions/node_modules/.bin/tsc -p functions/
7979
# Deploy functions, and security rules for database and Firestore. If the deploy fails, retry twice
8080
if [[ "${TOKEN}" == "" ]]; then
81-
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions,database,firestore && break; done
81+
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --only functions:integration-tests,database,firestore && break; done
8282
else
83-
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions,database,firestore && break; done
83+
for i in 1 2 3; do firebase deploy --project="${PROJECT_ID}" --token="${TOKEN}" --only functions:integration-tests,database,firestore && break; done
8484
fi
8585
}
8686

0 commit comments

Comments
 (0)