Skip to content

Commit 19f01c3

Browse files
authored
feat(storage): allow non default service account (#11137)
* test(storage): re-enable DetectDirectConnectivity integration test * feat(storage): allow non default service account
1 parent d4cacde commit 19f01c3

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

storage/grpc_client.go

+4-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,10 @@ func defaultGRPCOptions() []option.ClientOption {
101101
)
102102
} else {
103103
// Only enable DirectPath when the emulator is not being targeted.
104-
defaults = append(defaults, internaloption.EnableDirectPath(true), internaloption.EnableDirectPathXds())
104+
defaults = append(defaults,
105+
internaloption.EnableDirectPath(true),
106+
internaloption.EnableDirectPathXds(),
107+
internaloption.AllowNonDefaultServiceAccount(true))
105108
}
106109

107110
return defaults

storage/integration_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,6 @@ var readCases = []readCase{
327327
}
328328

329329
func TestIntegration_DetectDirectConnectivity(t *testing.T) {
330-
t.Skip("direct connectivity not yet available for CI")
331330
ctx := skipHTTP("direct connectivity isn't available for json")
332331
multiTransportTest(ctx, t, func(t *testing.T, ctx context.Context, bucket string, prefix string, client *Client) {
333332
h := testHelper{t}

0 commit comments

Comments
 (0)