Skip to content

configuration-sample extension falsely claims glob support #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Arnatious opened this issue Feb 6, 2025 · 1 comment
Open

configuration-sample extension falsely claims glob support #1144

Arnatious opened this issue Feb 6, 2025 · 1 comment
Assignees

Comments

@Arnatious
Copy link

Extension sample

Configuration Example

VS Code version

1.96.4

What went wrong?

Comments and labels in

"description": "Resource configuration: Configure files using glob patterns to have an empty last line always",
and
// 1) Get the configured glob pattern value for the current file
const value: any = vscode.workspace.getConfiguration('', e.uri).get('conf.resource.insertEmptyLastLine');
// 2) Check if the current resource matches the glob pattern
const matches = value ? value[e.fileName] : undefined;
claim that the extension is working with glob patterns, but the extension is just looking up strings in an object, no glob matching happens anywhere.

This also gave me the false impression globs were something exposed to the extension API, which it doesn't seem is the case.

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2025

Fix - #1145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants