Skip to content

Inconsistency in recency unit specification across documentation #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jungyanl opened this issue Dec 30, 2024 · 1 comment
Closed

Inconsistency in recency unit specification across documentation #1375

jungyanl opened this issue Dec 30, 2024 · 1 comment

Comments

@jungyanl
Copy link

jungyanl commented Dec 30, 2024

There appears to be a discrepancy in the documentation regarding the unit of measurement for the recency value in the browserSignals object within generateBid().

Conflicting Information

  1. In the Protected Audience API documentation, it states:

    recency in generateBid()'s browser signals is specified in milliseconds

  2. However, in the Extended Private Aggregation Reporting documentation, it states:

    The browserSignals.recency value inside generateBid() specifies the duration in minutes since the user joined the interest group.

Observation

Based on the values observed in generateBid(), it appears that milliseconds is the more likely correct unit of measurement.

Request for Clarification

Could the correct unit of measurement for the recency value be confirmed and the documentation updated accordingly to ensure consistency across all references?

This clarification would be beneficial for developers implementing the Protected Audience API to avoid potential misinterpretations or errors in their code.

@JensenPaul
Copy link
Collaborator

Thank you for bringing this to our attention. Milliseconds is in fact the correct units for recency. We've update the documentation to correct the units. I'm closing this issue as I think we've addressed it. If you have further concerns, feel free to file another issue. Also, @jungyanl, please add your name and affiliation to your GitHub profile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants