-
Notifications
You must be signed in to change notification settings - Fork 602
[vertexai] Include appcheck token unconditionally #6409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The app check backend can differentiate between apps that do not use appcheck at all, and those sending invalid data, by using a special placeholder token when errors happen. We were previously not including the token value in error cases, but we should.
Release note changesThe following release notes were modified. Please ensure they look correct. Release Notesfirebase-vertexai### {{firebase_vertexai}} version 16.0.2 {: #vertex-ai_v16-0-2}
* {{fixed}} Fixed issue where Firebase App Check error tokens were unintentionally missing from the requests. GitHub [#6409](//github.com/firebase/firebase-android-sdk/issues/6409){: .external}
|
Vertex AI Mock Responses Check
|
Test Results 20 files - 1 002 20 suites - 1 002 15s ⏱️ - 36m 12s Results for commit 09c3ef9. ± Comparison against base commit d96507b. This pull request removes 5697 tests.
♻️ This comment has been updated with latest results. |
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: rachelsaunders <[email protected]>
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/GenerativeModel.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: rachelsaunders <[email protected]>
…/GenerativeModel.kt Co-authored-by: rachelsaunders <[email protected]>
The app check backend can differentiate between apps that do not use appcheck at all, and those sending invalid data, by using a special placeholder token when errors happen. We were previously not including the token value in error cases, but we should.