Skip to content

[vertexai] Include appcheck token unconditionally #6409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Oct 24, 2024
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented Oct 23, 2024

The app check backend can differentiate between apps that do not use appcheck at all, and those sending invalid data, by using a special placeholder token when errors happen. We were previously not including the token value in error cases, but we should.

The app check backend can differentiate between apps that do not use
appcheck at all, and those sending invalid data, by using a special
placeholder token when errors happen. We were previously not including
the token value in error cases, but we should.
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-vertexai
### {{firebase_vertexai}} version 16.0.2 {: #vertex-ai_v16-0-2}

* {{fixed}} Fixed issue where Firebase App Check error tokens were unintentionally missing from the requests. GitHub [#6409](//github.com/firebase/firebase-android-sdk/issues/6409){: .external}

Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v5.1

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Test Results

 20 files   -  1 002   20 suites   - 1 002   15s ⏱️ - 36m 12s
112 tests  -  5 697  112 ✅  -  5 675  0 💤  - 22  0 ❌ ±0 
224 runs   - 11 479  224 ✅  - 11 435  0 💤  - 44  0 ❌ ±0 

Results for commit 09c3ef9. ± Comparison against base commit d96507b.

This pull request removes 5697 tests.
com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

@rlazo rlazo requested a review from rachelsaunders October 24, 2024 02:32
rlazo and others added 2 commits October 24, 2024 01:50
@rlazo rlazo requested a review from rachelsaunders October 24, 2024 05:58
@rlazo rlazo merged commit ec48742 into main Oct 24, 2024
26 of 27 checks passed
@rlazo rlazo deleted the rl.appcheck.dummy.token branch October 24, 2024 19:06
@firebase firebase locked and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants