[VertexAI] Log warning for unsupported model names #6805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a warning message to the initializers of GenerativeModel and
ImagenModel that is logged when the provided model name does not start
with the expected prefix ("gemini-" for GenerativeModel and "imagen-"
for ImagenModel). The warning message includes a link to the
documentation for supported models.
Note: No error is thrown in case the naming scheme is changed in the
future, though we would want to update the logic/message at that time.
Related iOS PR firebase/firebase-ios-sdk#14610
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
Coverage Report 1Affected ProductsNo changes between base commit (8a72ed5) and merge commit (01da78f).Test Logs |
|
The public api surface has changed for the subproject firebase-dataconnect_api.txt: Please update the api.txt files for the subprojects being affected by this change by running ./gradlew ${subproject}:generateApiTxtFile. Also perform a major/minor bump accordingly. |
Size Report 1Affected Products
Test Logs |
VinayGuthal
approved these changes
Mar 25, 2025
tejasd
pushed a commit
that referenced
this pull request
Apr 1, 2025
Added a warning message to the initializers of GenerativeModel and
ImagenModel that is logged when the provided model name does not start
with the expected prefix ("gemini-" for GenerativeModel and "imagen-"
for ImagenModel). The warning message includes a link to the
documentation for supported models.
Note: No error is thrown in case the naming scheme is changed in the
future, though we would want to update the logic/message at that time.
Related iOS PR firebase/firebase-ios-sdk#14610
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a warning message to the initializers of GenerativeModel and ImagenModel that is logged when the provided model name does not start with the expected prefix ("gemini-" for GenerativeModel and "imagen-" for ImagenModel). The warning message includes a link to the documentation for supported models.
Note: No error is thrown in case the naming scheme is changed in the future, though we would want to update the logic/message at that time.
Related iOS PR firebase/firebase-ios-sdk#14610