-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Firebase/Performance crashes Password Autofill screen #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for the report, also tracked internally at b/123065386. @visumickey can you investigate and see if Perf is the cause or not? It doesn't look like there are Firebase references in the stack trace, but a few users seem to think Perf is the issue. |
@Igor-Palaguta Can you share the detailed stack trace for this issue? Firebase performance does not have anything related to the UIActivity on the screen, so it is surprising to hear that the issue is related to UIActions. If this is predictably reproduce-able, can you share any sample app? It would be helpful to understand the version of the Firebase Performance POD you are using. (Note: Firebase Performance will have its own version number in the Podfile.lock). |
Cartfile.resolved binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseABTestingBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebasePerformanceBinary.json" "5.15.0"
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseRemoteConfigBinary.json" "5.15.0" I could not replicate this issue, just can see crashes in fabric, but some people could do it: https://stackoverflow.com/questions/52879044/crash-in-uikitcore-uiviewcontroller-viewdidmovetowindowshouldappearordisappear#comment93141683_52879044 Yesterday in stackoverflow appeared answer that after removing Firebase/Performance issue gone. |
Hi, Here is my test project https://github.com/Batvos/firebaseperfomanceissue where you can reproduce this crash. |
@Batvos test app looks empty |
Ops, Sorry. I don't know how it happened:) I'll push a normal version today later |
@Igor-Palaguta I've updated project. But you need to download your own GoogleService-Info.plist file from firebase project and add it to the root of project. Also you need to install pods. |
This looks like a very tricky issue. We are able to reproduce the issue, but we are trying ways to find the root cause to have a fix on this. Will keep investigating this crash to arrive at a solution soon. |
Any update? |
Can confirm that after removing Firebase/Performance library we don't see this crash any more |
Also seeing this crash when we added |
Indeed Firebase/Performance framework is causing the crash. To reproduce the crash, on sign up screen when the password textfield(secure text entry) is active put the app into background. |
Any update on this issue? |
We use firebase performance and have this crash as well. I can't see anything about firebase performance in the crash logs however. I have been able to reproduce it, but not consistently. The crashes seems a bit random to me right now. In our logs we often see that the users who experience this crash often goes to background. But I have been able to reproduce at times without it as well. Here is a typical crashlog if someone finds it useful: crashlog.txt UPDATE: Our next release will be without firebase performance, will get back here with results about if we still get the crash logs then. UPDATE 2: Our next release is out without firebase performance and this crash is not appearing 🎉 |
@Igor-Palaguta Need one more information to debug this further. Do we know the version of Firebase from where this issue has started spiking? |
@visumickey we started to use Firebase Performance since October 2018. And it was |
We have the same crash on production app |
same here |
We have nailed down the issue here and we working on a fix for this. The upcoming release should have the fix rolled out. |
Hey @visumickey, do you have any perspective about when this fix will be released? This is the top crash for my side, unfortunately 😅 |
At this time, we are planning to have this launched at M45. Planned to be available to the developers March 19 (M45). |
We have very frequent crash 0.5 % of all users who visited registration screen with password autofill fields. We started to have it after adding Firebase/Performance. Also we have confirmation from other developers that after removing Firebase/Performance it stopped crashing. Here is related discussion https://stackoverflow.com/a/54227163/2035054
The text was updated successfully, but these errors were encountered: