Skip to content

Firebase Performance warns me to add Analytics, which is not available on Catalyst #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
steipete opened this issue Mar 10, 2021 · 7 comments · Fixed by #7719
Closed

Firebase Performance warns me to add Analytics, which is not available on Catalyst #7693

steipete opened this issue Mar 10, 2021 · 7 comments · Fixed by #7719

Comments

@steipete
Copy link
Contributor

[REQUIRED] Step 1: Describe your environment

  • Xcode version: 12.4
  • Firebase SDK version: 7.8
  • Installation method: Zip file
  • Firebase Component: Performance

[REQUIRED] Step 2: Describe the problem

Screen Shot 2021-03-10 at 14 06 08

When building, I see a warning that asks me to add Firebase Analytics when using Performance, however we build for Catalyst and Analytics is not available there.

Seems related to #4563

Steps to reproduce:

Integrate from Zip. Add Performance. Archive Catalyst app.

@steipete
Copy link
Contributor Author

Side note - we can finally ship Crashlytics for our Catalyst app, super excited about this. Thanks for handling my last bug report so quickly!

@paulb777
Copy link
Member

@steipete Thanks for the report. This issue - #7487 - was just fixed in the 7.8.0 release. Did you update the Firebase.h from the the 7.8.0 zip download?

@paulb777 paulb777 added the zip Issues related to binary distribution (zip file) label Mar 10, 2021
@steipete
Copy link
Contributor Author

I indeed forgot to update it, but updating didn't resolve the issue.

If I look at the header it's clear why. See the selected part for the fix:
Screen Shot 2021-03-10 at 18 25 36

@steipete
Copy link
Contributor Author

Ah - or am I responsible for setting FIREBASE_ANALYTICS_SUPPRESS_WARNING somewhere?

@paulb777
Copy link
Member

Oops! Thanks for pointing that out. We'll get it updated for the next release.

FIREBASE_ANALYTICS_SUPPRESS_WARNING should only be needed by iOS Remote Config users wanting to suppress the warning.

We'll need to discuss with the Performance and RemoteConfig teams the right fix for iOS since Performance doesn't need Analytics, but its dependency RemoteConfig might want the warning? But either way, there shouldn't be the need for Catalyst and your suggestion should be applied.

@paulb777 paulb777 added api: remoteconfig and removed zip Issues related to binary distribution (zip file) labels Mar 10, 2021
@steipete
Copy link
Contributor Author

Thanks for looking into this! I'd also take a Catalyst build of Analytics, would make things simpler :)

@paulb777
Copy link
Member

Sent #7719 to fix and reopened #7487 for the related iOS issue

@firebase firebase locked and limited conversation to collaborators Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants