Skip to content

Fix mutating array during iteration crash #11379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

Fix mutating array during iteration crash #11379

merged 1 commit into from
Jun 1, 2023

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jun 1, 2023

Fix #11378

@paulb777 paulb777 added this to the 10.11.0 - M133 milestone Jun 1, 2023
@paulb777 paulb777 requested review from morganchen12 and karenyz June 1, 2023 20:34
morganchen12
morganchen12 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you know where experiments is being concurrently mutated, it might be helpful to add in a comment for future investigators since it's not obvious this change fixes a crash. If not no worries.

@paulb777
Copy link
Member Author

paulb777 commented Jun 1, 2023

I don't. This fix makes ABTExperimentsToClearFromPayloads consistent with ABTExperimentsToSetFromPayloads so besides the crash report, the missing copy looks like an oversight from the internal cl/252846485

@paulb777 paulb777 merged commit b1d5038 into master Jun 1, 2023
@paulb777 paulb777 deleted the pb-mutable-array branch June 1, 2023 22:13
@firebase firebase locked and limited conversation to collaborators Jul 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morganchen12 morganchen12 morganchen12 approved these changes

@karenyz karenyz karenyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.11.0 - M133
Development

Successfully merging this pull request may close these issues.

Crash in ABTExperimentsToClearFromPayloads
4 participants
@paulb777 @morganchen12 @karenyz @google-oss-bot