Skip to content

fix(auth): deprecate Microsoft provider method not used for authentication #17094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

russellwheatley
Copy link
Member

Description

Flutter Auth documentation already uses correct sign-in method: https://firebase.google.com/docs/auth/flutter/federated-auth?#microsoft

Both Firebase android and iOS documentation use provider to sign-in with Microsoft.

Firebase documentation states you cannot use access token based credentials to sign in: https://firebase.google.com/docs/auth/ios/microsoft-oauth?_gl=1*1rjsp43*_up*MQ..*_ga*OTM3NzY0NDIuMTczOTUzMjc1Mw..*_ga_CW55HF8NVT*MTczOTUzMjc1My4xLjAuMTczOTUzMjc1My4wLjAuMA..#expandable-2

Related Issues

closes #16598

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit 2371d2d into main Feb 14, 2025
27 of 29 checks passed
@russellwheatley russellwheatley deleted the auth-16598 branch February 14, 2025 14:16
@firebase firebase locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Firebase_Auth]: MicrosoftCredentials not working in signInWithCredential
4 participants