feat: Add PreparedStatement and update ExecuteQuery API to use it #2534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't do anything yet. I will follow with: - Refactoring of type converion code to populate param types - Connect PreparedStatement to ExecuteQuery - PreparedStatement refresh implementation Change-Id: I98f32cd65fee3dd43605f6353f0a4d6ad52630c8
Use it to populate paramTypes in PrepareQueryRequest Change-Id: I8340741fd7377a9e2b87972366ad74ed0cb3354a
This makes a series of changes to use the result of PrepareQuery for execute: - Replace Statement with a BoundStatement based on PreparedStatement - set preparedQuery in request, rather than 'query' - Use the metadata response from Prepare, this will no longer be present in the execute stream - Update Metadata future handling to work well with PrepareQuery refresh in the future Change-Id: Ie3249d0c0bd422b4aaf1c8878660d27288b4b6b0
Change-Id: Ifbe25eec9fd7d1a79d67d1629ec1782c067ab008
This incorporates the checksum & reset logic added since preview. It also updates the metadata resolution to be deffered until the first resume token has been received (see comment) Change-Id: I0eda81f85e86a7747c6ce2750dbeaa1f8d0d09b4
Renames MetadataResolvingCallable to PlanRefreshingCallable as this will be the place we handle plan refresh & metadata resolution Change-Id: I6d5329ced6d9a4228a3a49fbc8b5f497d8678cce Change-Id: I92dcde9e67459e0b8119b4c9d216a47fb6819758
Change-Id: I7a83e84d689e438c32c4e9a320b6fff52d86e0de
Change-Id: I22cdeb1560a0975c8f2ff380ca30f3e09070417d
…exclusions for changed beta api This also temporarily disables the ExecuteQuery conformance tests so they can be rewritten to use Prepare. Updated local copies of the tests are passing Also fixes BoundStatement docs I missed in previous PR Change-Id: I9024d50fff3c076064b8277fd4a5aa426e0b5de4
Change-Id: I5f73a4af1588d015e7e0edebf3ec73e188bf216e
8ed8dae to
85fd11a
Compare
Change-Id: Iea243f2c89872f947b5b79e37fa507e403f5acea
85fd11a to
4b1ac32
Compare
andre-sampaio
approved these changes
Mar 24, 2025
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 24, 2025
🤖 I have created a release *beep* *boop* --- ## [2.57.0](https://togithub.com/googleapis/java-bigtable/compare/v2.56.0...v2.57.0) (2025-03-24) ### Features * Add PreparedStatement and update ExecuteQuery API to use it ([#2534](https://togithub.com/googleapis/java-bigtable/issues/2534)) ([49d4d09](https://togithub.com/googleapis/java-bigtable/commit/49d4d09fd16a1eb4eb566227a049bca2aaaa61e3)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.