Skip to content

fix: mergeSchemaWithRows can be called with empty schema if result set is empty #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 2, 2025
Merged

fix: mergeSchemaWithRows can be called with empty schema if result set is empty #1455

merged 4 commits into from
Apr 2, 2025

Conversation

alvarowolfx
Copy link
Contributor

Fixes #1452 🦕

@alvarowolfx alvarowolfx requested a review from leahecole April 1, 2025 17:13
@alvarowolfx alvarowolfx requested review from a team as code owners April 1, 2025 17:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Apr 1, 2025
@alvarowolfx alvarowolfx mentioned this pull request Apr 1, 2025
Closed
7 tasks
@alvarowolfx alvarowolfx merged commit e608601 into main Apr 2, 2025
18 checks passed
@alvarowolfx alvarowolfx deleted the fix-get-rows-empty-table branch April 2, 2025 19:22
@release-please release-please bot mentioned this pull request Apr 2, 2025
Merged
This was referenced Apr 22, 2025
Open
Open
Open
@julienvincendeau-rc
Copy link

Thanks for this fix! However, we're seeing some unexpected behavior in production related to the JSON schema generated by the connector. It seems this change might be interacting in a way we didn't anticipate. Any thoughts on how to best address this?
image

ping @g-lalevee @baptiste-omarini-rc

@alvarowolfx
Copy link
Contributor Author

Thanks for this fix! However, we're seeing some unexpected behavior in production related to the JSON schema generated by the connector. It seems this change might be interacting in a way we didn't anticipate. Any thoughts on how to best address this?

image

ping @g-lalevee @baptiste-omarini-rc

can you provide an example to reproduce the issue ? From that screenshot I couldn't understand the issue that you reported and which feature from this library you're referring to.

@julienvincendeau-rc
Copy link

We use this feature throw Google Connector BQ. When you publish this connector on GCP, schema is seems reloaded throw this librairies. We might be misunderstanding. We open an issue on GCP too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

table.getRows throws TypeError: Cannot read properties of undefined (reading 'fields')
3 participants
@alvarowolfx @julienvincendeau-rc @leahecole