Skip to content

fix(getFiles): add nextPageToken to fields for autoPaginate #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

fix(getFiles): add nextPageToken to fields for autoPaginate #2570

merged 1 commit into from
Jan 17, 2025

Conversation

jjaareet
Copy link
Contributor

@jjaareet jjaareet commented Jan 14, 2025 •
edited
Loading

bucket.getFiles() - returns all files as expected
bucket.getFiles({fields: 'items(name)'}) - unexpectedly returns only 1,000 files

i noticed that autoPaginate and fields do not play nicely together unless nextPageToken is added to fields. hoping to prevent someone else from banging their head on that wall with this change

edit: sorry for the force push after requesting review, just noticed a typo in the commit message

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Jan 14, 2025
@jjaareet jjaareet marked this pull request as ready for review January 14, 2025 16:43
@jjaareet jjaareet requested review from a team as code owners January 14, 2025 16:43
@jjaareet jjaareet changed the title fix(getFiles): add nextPageTokento fields for autoPaginate fix(getFiles): add nextPageToken to fields for autoPaginate Jan 14, 2025
@ddelgrosso1 ddelgrosso1 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 14, 2025
@ddelgrosso1
Copy link
Contributor

@jjaareet thank you for the contribution!

@ddelgrosso1 ddelgrosso1 merged commit 75c309c into googleapis:main Jan 17, 2025
15 checks passed
@release-please release-please bot mentioned this pull request Jan 17, 2025
Merged
ddelgrosso1 added a commit that referenced this pull request Mar 4, 2025
@thiyaguk09 @ddelgrosso1
@release-please @gcf-owl-bot @danielduhh @jjaareet
chore!: gaxios rebase node 18 (#2569)
7ec0bf7 
* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* feat: add ability to configure and utilize soft-delete and restore buckets (#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* fix

* chore(cleanup)!: Remove teeny-request in favor of gaxios/authclient

* remove service class and associated tests

* modify service-object and associated sub classes to use storage transport

* begin refactoring classes to use storage-transport

* finish initial refactor of classes

* fix compilation errors

* add header to storage-transport.ts

* fix service-object unit tests

* fix common-util tests

* fix acl tests

* fix channel tests

* fix headers tests

* fix iam tests

* fix index tests

* fix notification tests

* remove teeny-request and retry request from deps

* fix arguments and urls of create bucket

* fix multipart upload urls

* fix stream handling in createReadStream

* fix compilation errors

* fix lint issues

fix lint issues

* test case fix

* lint fix

lint fix

* lint and test case fix

lint and test case fixes

* chore(main): release 7.15.0 (#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (#2571)

* fix bucket tests

* fix(getFiles): add nextPageToken to fields for autoPaginate (#2570)

* fix storage-transport test

* fix file tests

* conformance test fix

* fix error

* fix buffer error

* comment failed conformance test

* comments addressed

* refactoring the storage-transport classes to utilize Promises

* chore: fix type errors in build (#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix license issue

---------

Co-authored-by: Denis DelGrosso <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <[email protected]>
Co-authored-by: Jarrett <[email protected]>
Co-authored-by: Denis DelGrosso <[email protected]>
ddelgrosso1 added a commit that referenced this pull request Mar 13, 2025
@thiyaguk09 @release-please
@gcf-owl-bot @danielduhh @jjaareet @ddelgrosso1 @terite
fix: Improve projectId handling in authentication (#2584)
6d94e45 
* feat: add ability to configure and utilize soft-delete and restore buckets (#2566)

* Adds support for the restore token feature

* description fix

* lint fix

* fetch softDeleted bucket list & details

fetch softDeleted bucket list & details

* initial commit for bucket restore

initial commit for bucket restore

* fix missing license headers

fix missing license headers

* lint fix

* test case bug fix

* added restore bucket unit test cases

* added restore bucket system test

added restore bucket system test

* lint fix

* format

format

* system test fix

* chore(main): release 7.15.0 (#2568)

* chore(main): release 7.15.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: replace reference docs link with RAD (#2571)

* fix(getFiles): add nextPageToken to fields for autoPaginate (#2570)

* chore: fix type errors in build (#2577)

* chore: fix type errors in build

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix docs links

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* chore(main): release 7.15.1 (#2573)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* fix: export SaveData type from index.ts (#2580)

* chore(main): release 7.15.2 (#2581)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: set gcs-sdk-team as CODEOWNERS  (#2582)

* Set CODEOWNERS as gcs-sdk-team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* update repo metadata with new team

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix broken types causing compilation failures

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Denis DelGrosso <[email protected]>

* fix: Improve projectId handling in authentication

Improve projectId handling in authentication and resolve issue in patch
request

* bug fix

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Daniel B <[email protected]>
Co-authored-by: Jarrett <[email protected]>
Co-authored-by: Denis DelGrosso <[email protected]>
Co-authored-by: David Stensland <[email protected]>
Co-authored-by: Denis DelGrosso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjaareet @ddelgrosso1 @yoshi-kokoro