Skip to content

mypy presubmit fails at HEAD with mypy 1.11+ #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea opened this issue Aug 1, 2024 · 2 comments · Fixed by #768
Closed

mypy presubmit fails at HEAD with mypy 1.11+ #682

parthea opened this issue Aug 1, 2024 · 2 comments · Fixed by #768
Assignees
@parthea
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Collaborator

parthea commented Aug 1, 2024

See this build log which shows that mypy is failing at head with

google/api_core/grpc_helpers_async.py:157: error: Type application targets a non-generic function or class  [misc]
tests/asyncio/test_grpc_helpers_async.py:3[18](https://github.com/googleapis/python-api-core/actions/runs/10182615581/job/28165602524?pr=681#step:5:19): error: Type application targets a non-generic function or class  [misc]

The issue exists with mypy 1.11.0 and newer and started on July 19th

https://pypi.org/project/mypy/#history
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Aug 1, 2024
parthea added a commit that referenced this issue Aug 1, 2024
@parthea
build: use mypy<1.11.0 until #682 is fixed
63d593e
@parthea parthea mentioned this issue Aug 1, 2024
Merged
@parthea parthea assigned daniel-sanche and unassigned parthea Aug 1, 2024
@parthea
Copy link
Collaborator Author

parthea commented Aug 1, 2024

@daniel-sanche Please could you take a look?

parthea added a commit that referenced this issue Aug 1, 2024
@parthea
build: use mypy<1.11.0 until #682 is fixed (#683)
6d1b96b 
* build: use mypy<1.11.0 until #682 is fixed

* add comment
@daniel-sanche daniel-sanche mentioned this issue Dec 16, 2024
Merged
@daniel-sanche
Copy link
Contributor

I put together a fix at #768, let me know what you think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@parthea parthea

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(types): update mypy version googleapis/python-api-core
2 participants
@daniel-sanche @parthea