Skip to content

feat: add caching to GapicCallable #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 21, 2024
Merged

feat: add caching to GapicCallable #666

merged 35 commits into from
Oct 21, 2024

Conversation

parthea
Copy link
Collaborator

@parthea parthea commented Jun 4, 2024

Opening a new PR to restore the features in #527 which were reverted in #665 due to #660

cc @daniel-sanche

BEGIN_COMMIT_OVERRIDE
chore: add caching to GapicCallable
END_COMMIT_OVERRIDE

@parthea parthea requested review from a team as code owners June 4, 2024 14:29
@parthea parthea changed the title Optimize gapic callable feat: add caching to GapicCallable Jun 4, 2024
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 4, 2024
@parthea parthea assigned daniel-sanche and unassigned vchudnov-g Jun 4, 2024
@parthea parthea marked this pull request as draft June 4, 2024 14:32
Copy link
Contributor

@daniel-sanche daniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche
Copy link
Contributor

@parthea Just changed the metadata type to a list, and added types to a docstring

@parthea parthea assigned parthea and unassigned daniel-sanche Oct 21, 2024
@parthea parthea added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 21, 2024
@parthea
Copy link
Collaborator Author

parthea commented Oct 21, 2024

Waiting for test results in cl/688135988 Tests passed

@parthea parthea removed status: investigating The issue is under investigation, which is determined to be non-trivial. do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 21, 2024
@parthea parthea marked this pull request as ready for review October 21, 2024 15:10
@parthea parthea merged commit 1695119 into main Oct 21, 2024
43 checks passed
@parthea parthea deleted the optimize_gapic_callable branch October 21, 2024 15:11
parthea added a commit that referenced this pull request Oct 23, 2024
parthea added a commit that referenced this pull request Oct 23, 2024
@parthea parthea added the release-please:force-run To run release-please label Oct 23, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants