Skip to content

docs: correct the docs for option_context #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 8, 2023
Merged

docs: correct the docs for option_context #263

merged 3 commits into from
Dec 8, 2023

Conversation

ashleyxuu
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue #315382764 🦕

@ashleyxuu ashleyxuu requested a review from shobsi December 8, 2023 00:16
@ashleyxuu ashleyxuu requested review from a team as code owners December 8, 2023 00:16
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Dec 8, 2023
@GarrettWu GarrettWu added the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit d21c6dd into main Dec 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the ashleyxu-correct-option-xontext branch December 8, 2023 19:52
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 8, 2023
@release-please release-please bot mentioned this pull request Dec 8, 2023
Merged
Genesis929 pushed a commit that referenced this pull request Dec 12, 2023
@ashleyxuu @Genesis929
docs: correct the docs for option_context (#263)
ae28c1d 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/python-bigquery-dataframes/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes internal issue #315382764 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GarrettWu GarrettWu GarrettWu approved these changes

@shobsi shobsi Awaiting requested review from shobsi

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashleyxuu @GarrettWu