fix: Extend row hash to 128 bits to guarantee unique row id #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbfac1c to
02c0f32
Compare
Looks like a test flake. Will raise an issue with our on-call this week. |
tswast
requested changes
Apr 25, 2024
bigframes/session/__init__.py
Outdated
| @@ -832,9 +834,13 @@ def _read_gbq_table( | |||
| ordering=ordering, | |||
| ) | |||
| else: | |||
| array_value = self._create_total_ordering(table_expression) | |||
| array_value = self._create_total_ordering( | |||
| table_expression, table_size=table.num_rows | |||
There was a problem hiding this comment.
Could you please try this with a VIEW type table? I don't think num_rows is always populated.
There was a problem hiding this comment.
yes, this won't be populated for views or potentially with streaming inserts. defaulting to assume table is large and need 128 bits.
bigframes/session/__init__.py
Outdated
| @@ -1455,10 +1461,18 @@ def _create_empty_temp_table( | |||
| def _create_total_ordering( | |||
| self, | |||
| table: ibis_types.Table, | |||
| table_size: int, | |||
There was a problem hiding this comment.
Likewise, we might need to handle missing size here.
eedd123 to
318609e
Compare
tswast
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕