feat: enable read_csv() to process other files #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e6b93a to
b952e30
Compare
b952e30 to
fa68d2d
Compare
GarrettWu
reviewed
Sep 3, 2024
tests/system/small/test_session.py
Outdated
| ], | ||
| ) | ||
| def test_read_csv_others(session, scalars_pandas_df_index, engine): | ||
| # TODO: Update to `main` branch after merging https://github.com/googleapis/python-bigquery-dataframes/pull/938 |
| "bigquery", | ||
| id="bq_engine", | ||
| marks=pytest.mark.xfail( | ||
| raises=NotImplementedError, |
There was a problem hiding this comment.
So it only available in default engine? We should update the docs to be explicit. Also should update the doc that we support global paths(currently says local only).
There was a problem hiding this comment.
Good catch! Done.
GarrettWu
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal issue 361420947 🦕