Skip to content

Allow running istio-cni as unprivileged #52558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keithmattix opened this issue Aug 7, 2024 · 1 comment · Fixed by #53478
Closed

Allow running istio-cni as unprivileged #52558

keithmattix opened this issue Aug 7, 2024 · 1 comment · Fixed by #53478

Comments

@keithmattix
Copy link
Contributor

keithmattix commented Aug 7, 2024

Describe the feature request
Today, the main istio-cni container runs as a Daemonset with privileged: true. This isn't great to have a privileged container running on every node; instead, we should do whatever privileged actions are necessary in a separate initcontainer (this is the approach kube-proxy takes: https://www.kubernetes.dev/blog/2024/01/05/kube-proxy-non-privileged/). Note that the repair controller currently requires privileged: true because it reads procfs; we should allow turning that off if we don't already. Users may have other options (e.g. a cloud provider process) for handling the race-conditions, so istio-cni should be able to turn off that functionality

Describe alternatives you've considered

Affected product area (please put an X in all that apply)

[ ] Ambient
[ ] Docs
[ ] Dual Stack
[ ] Installation
[X] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

@jaellio
Copy link
Contributor

jaellio commented Aug 28, 2024

The repair controller can be disabled by setting values.cni.repair.enabled to false. https://istio.io/latest/docs/setup/additional-setup/cni/#race-condition--mitigation

@jaellio jaellio self-assigned this Sep 9, 2024
@jaellio jaellio linked a pull request Oct 11, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants