unset host, if set, before sending proxy cloud run/functions request #3025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtstern
approved these changes
Jan 13, 2021
src/hosting/proxy.ts
Outdated
| @@ -68,6 +68,11 @@ export function proxyRequestHandler(url: string, rewriteIdentifier: string): Req | |||
| Cookie: sessionCookie || "", | |||
| }); | |||
| for (const key of Object.keys(req.headers)) { | |||
| // Skip particular header keys: | |||
| // - using x-forwarded-host, don't need to keep `host` in the headers. | |||
| if (["host"].includes(key)) { | |||
There was a problem hiding this comment.
Why ["host"].includes(key) and not key === "host"? Was this maybe a longer list at first?
There was a problem hiding this comment.
I had a headers.delete("host") below before but didn't want that as a pattern. I figured being able to have a list here would be great just in case there were other headers a proxy shouldn't actually be sending.
There was a problem hiding this comment.
Then maybe do two lines:
const headersToDelete = ["host"];
if (headersToDelete.includes(key)) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I cannot keep
hostset while proxying as it breaks the outbound request since it won't match the URL we're going for.Fixes #3012
Scenarios Tested