Skip to content

fix: remove call credentials from call options if DirectPath #3670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 10, 2025
Merged

fix: remove call credentials from call options if DirectPath #3670

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ae471b3
remove call credentials from call options if DirectPath
rockspore Mar 1, 2025
39489bc
fix ctor issue
rockspore Mar 1, 2025
f7244a8
add tests
rockspore Mar 3, 2025
618c321
fix tests
rockspore Mar 3, 2025
4c739ea
fix tests
rockspore Mar 3, 2025
11ce53e
fix typo and slightly more coverage
rockspore Mar 3, 2025
19920fa
make the getter dumb
rockspore Mar 5, 2025
255dcee
fix tests
rockspore Mar 5, 2025
f8232ca
address comment
rockspore Mar 5, 2025
d8765ad
Merge branch 'main' into grpc-creds-alt
rockspore Mar 5, 2025
9ac1291
address comment
rockspore Mar 7, 2025
06afd3e
Merge branch 'main' of https://github.com/googleapis/sdk-platform-jav…
rockspore Mar 7, 2025
abb1ba3
Merge branch 'grpc-creds-alt' of github.com:rockspore/sdk-platform-ja…
rockspore Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix typo and slightly more coverage
  • Loading branch information
@rockspore
rockspore committed Mar 3, 2025
commit 11ce53e933f27aacc2fb0ef9a705bf6bdab7c0ad
6 changes: 5 additions & 1 deletion gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/GrpcCallContextTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ void testWithTransportChannelWrongType() {
}

@Test
void testWithTransportChannelIsDirectcPath() {
void testWithTransportChannelIsDirectPath() {
ManagedChannel channel = Mockito.mock(ManagedChannel.class);
Credentials credentials = Mockito.mock(GoogleCredentials.class);
GrpcCallContext context = GrpcCallContext.createDefault().withCredentials(credentials);
Expand All @@ -114,6 +114,10 @@ void testWithTransportChannelIsDirectcPath() {
.setManagedChannel(channel)
.build());
assertNull(context.getCallOptions().getCredentials());

// This should revert isDirectPath to false.
context = context.withChannel(channel);
assertNotNull(context.getCallOptions().getCredentials());
}

@Test
Expand Down
Loading